sloccount-plugin icon indicating copy to clipboard operation
sloccount-plugin copied to clipboard

[JENKINS-74191][JENKINS-74192][JENKINS-74193][JENKINS-74194][JENKINS-74195] Fix CSP

Open yaroslavafenkin opened this issue 11 months ago • 1 comments

  • https://issues.jenkins.io/browse/JENKINS-74191
  • https://issues.jenkins.io/browse/JENKINS-74192
  • https://issues.jenkins.io/browse/JENKINS-74193
  • https://issues.jenkins.io/browse/JENKINS-74194
  • https://issues.jenkins.io/browse/JENKINS-74195

I suspect files.jelly, folders.jelly, languages.jelly and modules.jelly are unused. They can be navigated to directly by going to e.g. job/sloccount/17/sloccountResult/files, but Behaviour is not defined there, so the script tags in those files seem pointless. Did the regular extraction nevertheless in case I'm missing something.

Testing done

Before the change After the change

Submitter checklist

  • [ ] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • [ ] Ensure that the pull request title represents the desired changelog entry
  • [ ] Please describe what you did
  • [ ] Link to relevant issues in GitHub or Jira
  • [ ] Link to relevant pull requests, esp. upstream and downstream changes
  • [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

yaroslavafenkin avatar Dec 12 '24 14:12 yaroslavafenkin

My assumption is that the stuff is loaded via the index.jelly. Then it uses YAHOO tabview to load the pages and present them as tabs on the index page. As YAHOO is to be removed soon, that will stop working.

mawinter69 avatar Jan 06 '25 16:01 mawinter69