script-security-plugin icon indicating copy to clipboard operation
script-security-plugin copied to clipboard

Published 20 hours ago • verified publisher icon jenkinsci

[JENKINS-63668] fix: auto re-request approval once dismissed

Open meiswjn opened this issue 7 months ago • 14 comments

This PR resolves JENKINS-63668. If a job fails because a script is not approved, it automatically re-requests the approval. It also deprecates the current #using method and adds a new flag ignoreAdmin to it. This is due to concerns that administrators could unknowingly approve a script for everyone by running the job.

Should unblock #300 (hopefully - motivation behind this PR).

Testing done

  • Added automated test.
  • Followed previous reproduction steps from issue.
### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [x] Link to relevant issues in GitHub or Jira
- [x] Link to relevant pull requests, esp. upstream and downstream changes
- [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

meiswjn avatar Nov 27 '23 12:11 meiswjn