scoring-load-balancer-plugin icon indicating copy to clipboard operation
scoring-load-balancer-plugin copied to clipboard

[JENKINS-70726] Build result scoring skipped on pipeline jobs

Open vtwaldo21 opened this issue 1 year ago • 2 comments

Added support for Build Result scoring on pipeline jobs (was always returning 0) closes #64

https://issues.jenkins.io/browse/JENKINS-70726

Testing done

Verified that jobs were scored based on Build Result when the job was pipeline using the logging feature. Did not regression test that freestyle jobs continue to work.

Submitter checklist

  • [X] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • [X] Ensure that the pull request title represents the desired changelog entry
  • [X] Please describe what you did
  • [X] Link to relevant issues in GitHub or Jira
  • [X] Link to relevant pull requests, esp. upstream and downstream changes
  • [X] Ensure you have provided tests - that demonstrates feature works or fixes the issue

vtwaldo21 avatar Jul 21 '24 06:07 vtwaldo21

oh, i also had a second freebie commit for just some random code-cleanup/typos.

vtwaldo21 avatar Jul 21 '24 06:07 vtwaldo21

image Use the re-request review button when done to notify my for another review 🤗

viceice avatar Aug 22 '24 08:08 viceice