plugin-installation-manager-tool icon indicating copy to clipboard operation
plugin-installation-manager-tool copied to clipboard

Fix findPluginsToDownload falsely check installed version

Open anhcraft opened this issue 11 months ago • 0 comments

I noticed that PluginManager#findPluginsToDownload has a wrong logic if-else. For a requested plugin, if there is both installed plugin and bundled plugin, then the method only gets the version from the installed one without checking if the bundled one is newer. The else logic was added in c445deaa4ce961104f63995cf6c1ada59929e6ac

Testing done

I have adjusted the test case to suit the new changes.

Submitter checklist

- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [ ] Link to relevant issues in GitHub or Jira
- [ ] Link to relevant pull requests, esp. upstream and downstream changes
- [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

anhcraft avatar Mar 09 '24 03:03 anhcraft