plugin-installation-manager-tool icon indicating copy to clipboard operation
plugin-installation-manager-tool copied to clipboard

Split CLI to subcommands (and migrate to picocli)

Open oleg-nenashev opened this issue 4 years ago • 3 comments
trafficstars

Plugin Installation Manager Tool implements multiple commands at the moment, and options are a bit confusing. The tool would benefit from sub-commands (install-plugins, list-updates) that could simplify the interface for users and allow to easily extend it going forward.

Such a migration would also allow using Plugin Installation Manager as a subcommand on its own, e.g. inside Jenkinsfile Runner CLI which needs plugin management.

FTR https://groups.google.com/g/jenkinsci-dev/c/jTkOpdZ7z1s for the discussion. Reference migration: https://github.com/jenkinsci/jenkinsfile-runner/pull/432

oleg-nenashev avatar Dec 06 '20 21:12 oleg-nenashev

@timja @stopalopa @jetersen I have started a PoC for this change: https://github.com/jenkinsci/plugin-installation-manager-tool/pull/376 Will try to finalize it for reviews in a few days. Are we all onboard with a breaking change and Plugin Installation Manager 3.0?

oleg-nenashev avatar Oct 18 '21 05:10 oleg-nenashev

I am okay with breaking change especially because it allows for easier integration of new features.

jetersen avatar Oct 21 '21 10:10 jetersen

Breaking changes are fine here, ideally have an upgrade guide / command map table though.

I would just include in PR and release notes, maybe README can link to it (not a huge fan of leaving huge upgrade guides in READMEs)

timja avatar Oct 21 '21 11:10 timja