oidc-provider-plugin icon indicating copy to clipboard operation
oidc-provider-plugin copied to clipboard

Required environment variable matching for claim precedence

Open iwarapter opened this issue 2 years ago • 5 comments

  • [x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • [x] Ensure that the pull request title represents the desired changelog entry
  • [x] Please describe what you did
  • [x] Link to relevant issues in GitHub or Jira
  • [x] Link to relevant pull requests, esp. upstream and downstream changes
  • [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

As part of #22 I have had a (very rough) go at supporting required environment variables for claims.

I have outstanding issue on tests with missing descriptor java.lang.AssertionError: class java.lang.String is missing its descriptor in public final java.util.List io.jenkins.plugins.oidc_provider.config.ClaimTemplate.requiredEnvVars. See https://www.jenkins.io/redirect/developer/class-is-missing-descriptor not sure how to solve this for List of String.

iwarapter avatar Nov 12 '22 01:11 iwarapter

Thanks! I am pretty busy so I cannot promise to review this promptly but I will get to it when I can.

jglick avatar Nov 14 '22 23:11 jglick

Still have not had time to review I am afraid—too many things to juggle!

jglick avatar Dec 21 '22 21:12 jglick

hey @jglick, wondering if you had a chance to look at this?

iwarapter avatar May 15 '23 11:05 iwarapter

Not yet I am afraid.

jglick avatar May 15 '23 11:05 jglick

@iwarapter hi, I encountered similar issue with you, I tried a different path which is now working ! Try #35 with the prebuilt hpi package: https://ci.jenkins.io/job/Plugins/job/oidc-provider-plugin/job/PR-35/

LeoQuote avatar Dec 26 '23 11:12 LeoQuote