msbuild-plugin icon indicating copy to clipboard operation
msbuild-plugin copied to clipboard

Pipeline support [Fixes JENKINS-26948]

Open mdkf opened this issue 6 years ago • 6 comments

mdkf avatar Oct 26 '18 21:10 mdkf

@marshall777 could you review this changes ?

pavelpikta avatar Jan 14 '19 12:01 pavelpikta

Gentle ping to ask for this feature to be merged :smile:

burtonr avatar May 06 '19 16:05 burtonr

Ping here too

marcus-sonestedt avatar Jun 17 '19 09:06 marcus-sonestedt

@marshal777's last commit to github was Jan 11, 2018 (over 1.5 years ago). Is there anybody else able to review this? Looking at https://github.com/jenkinsci/msbuild-plugin/graphs/contributors it looks like this plugin is dead.

DamonStamper avatar Aug 05 '19 21:08 DamonStamper

is this pr about to be merged in the near future?

moshavnik avatar Oct 29 '19 14:10 moshavnik

Bump.

x86 avatar Dec 06 '21 13:12 x86

Closing this because a bat, powershell, or pwsh step should be used to call msbuild from Pipeline rather than creating special case logic inside this plugin. I agree with the observations from @jglick in https://github.com/jenkinsci/msbuild-plugin/pull/36#discussion_r340092182

MarkEWaite avatar Nov 20 '22 13:11 MarkEWaite

Closing this because a bat, powershell, or pwsh step should be used to call msbuild from Pipeline rather than creating special case logic inside this plugin.

Does this not mean we have to create special logic inside the jenkinsfile instead, which means the implementation details of a particular node are bleeding into the project source code?

I am setting this up right now and surprised at how difficult this appears to be.

minfrin avatar Mar 08 '24 09:03 minfrin

Does this not mean we have to create special logic inside the jenkinsfile instead, which means the implementation details of a particular node are bleeding into the project source code?

I am setting this up right now and surprised at how difficult this appears to be.

https://github.com/jenkinsci/msbuild-plugin/pull/36#discussion_r340159871 describes a technique that uses a Jenkins tool installer for each msbuild configuration and then references that tool from the Pipeline script. The Jenkins tool installer definitions are managed on the Jenkins controller. Other alternatives are discussed in that comment thread.

MarkEWaite avatar Mar 08 '24 16:03 MarkEWaite