mercurial-plugin icon indicating copy to clipboard operation
mercurial-plugin copied to clipboard

Add head name property in MercurialSCM

Open long76 opened this issue 1 year ago • 4 comments
trafficstars

If use resolveScm in usual pipeline you cannot get branch name - getRevision return hash althought resolveScm print and branch name too.

Testing done

Submitter checklist

  • [x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • [x] Ensure that the pull request title represents the desired changelog entry
  • [x] Please describe what you did
  • [ ] Link to relevant issues in GitHub or Jira
  • [ ] Link to relevant pull requests, esp. upstream and downstream changes
  • [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

long76 avatar Jun 04 '24 12:06 long76

@long76 thanks for the pull request. I think that it would be valuable to add a test of the new methods that have been added so that future changes do not break the new methods.

The Mercurial plugin is currently up for adoption. That means there is currently no active maintainer for the plugin. Since you are using the plugin, are you willing to adopt the plugin and become the maintainer of the plugin?

MarkEWaite avatar Jun 04 '24 12:06 MarkEWaite

@long76 thanks for the pull request. I think that it would be valuable to add a test of the new methods that have been added so that future changes do not break the new methods.

The Mercurial plugin is currently up for adoption. That means there is currently no active maintainer for the plugin. Since you are using the plugin, are you willing to adopt the plugin and become the maintainer of the plugin?

thanks but no) we migrate to git but this functionality would be useful. i make our local version this plugin and deploy them. so what happens first our migration or plugin has maintainer)

long76 avatar Jun 04 '24 12:06 long76

Feature does not require specific tests

Sure it does.

I guess the description is referring to https://github.com/jenkinsci/workflow-multibranch-plugin/blob/28fbf74dfcaeccbee5f7fbb1ae7d0d3c95cd932d/src/main/java/org/jenkinsci/plugins/workflow/multibranch/ResolveScmStep.java#L282 though it is not clear.

yes you are right. that's what i meant.

long76 avatar Jun 04 '24 13:06 long76

@jglick @MarkEWaite add tests

long76 avatar Jun 06 '24 15:06 long76