lockable-resources-plugin icon indicating copy to clipboard operation
lockable-resources-plugin copied to clipboard

Overview page looks ugly without lockable resources

Open TobiX opened this issue 5 years ago • 11 comments

When no lockable resources are defined, the overview page (http://localhost:8080/lockable-resources/) looks ugly since it only contains a header and a row-less table (since the default style doesn't assign a lower border for table headers, the table seems to be "open" at the bottom).

This page should act like a bit like the jobs page or an empty view: If there is nothing to show, show a reassuring message conveying the fact to the user.

TobiX avatar May 18 '20 17:05 TobiX

Wrote this in the irc earlier. Sorry for misunderstanding the UI; I think the missing links on the left in combination with the table headers as only elements led me to the conclusion of a broken configuration. I think a link on the left to add new resources would make a huge difference.

AiyionPrime avatar May 18 '20 17:05 AiyionPrime

This is what the page currently looks like: http://aiyionpri.me/shared/2020-05-18-jenkins.png

AiyionPrime avatar May 18 '20 17:05 AiyionPrime

Hi there,

Did you know if a Jenkins Jira ticket exists for this issue ?

Artmorse avatar Oct 12 '22 15:10 Artmorse

@Artmorse I've moved on, this is more than two years old; but I was under the impression this was the issue-tracker and did not know about an open Jira instance.

AiyionPrime avatar Oct 12 '22 15:10 AiyionPrime

This will be probably fixed by #339 The view is done by table. It will shos you just empty tables. There is no information about not-configured-resorces. But it doesn't looks broken anymore 😁 @TobiX pls verify it and close this issue or comment your findings here.

mPokornyETM avatar Oct 17 '22 21:10 mPokornyETM

Don't know. I created this as a tracking issue when I was maintaining this plugin, but am not using it anymore. Feel free to close if you think this issue is fixed.

TobiX avatar Oct 19 '22 10:10 TobiX

Ok, I see, I will retest it and close it, thx

mPokornyETM avatar Oct 19 '22 11:10 mPokornyETM

When we don't have defined any lockable resource, the Lockable Resource page look like that. image

Artmorse avatar Oct 20 '22 14:10 Artmorse

@Artmorse thx. It is much more better, like before. The my personal priority is now low, because the page is no more broken. But from my side, there is missing some info like 'Can not find any resources currently. config page'

mPokornyETM avatar Oct 20 '22 14:10 mPokornyETM

Ok! @mPokornyETM can you assign me the issue, tomorrow I'll work on it if you agree ? :)

Artmorse avatar Oct 20 '22 17:10 Artmorse

Not required to be "assigned", though it helps avoid redundant efforts :)

jimklimov avatar Oct 20 '22 18:10 jimklimov