JENKINS-46253 Add support for subPath to all volume types

[hameno]

Includes work from Miguel Campos (https://github.com/jenkinsci/kubernetes-plugin/pull/1024)

refs JENKINS-46253

• [x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• [x] Ensure that the pull request title represents the desired changelog entry
• [x] Please describe what you did
• [x] Link to relevant issues in GitHub or Jira
• [x] Link to relevant pull requests, esp. upstream and downstream changes
• [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

[mcamposv]

Dear Hameno, I'm no expert however before I placed my pull request I was told that we should not modify the existing API methods in a class. if you check my initial commit I changed the https://github.com/sprylab/kubernetes-plugin/commit/a309ac1687167d93e57d70ab1464b37328b144a6#diff-76b7e7535ea9463d5389851a958cc07955f2fcfbe99bb393079fdc6f70b0e46f

I created a new constructor but I maintained the old one that calls the new one: public ConfigMapVolume(String mountPath, String configMapName, Boolean optional) { this(mountPath, configMapName, optional, (String) null); }

If I'm not seeing wrong you changed the constructor but did not maintain the old one for compatibility purpose that might be a reason for the pull request to be rejected. could you please amend your code to maintain compatibility?

Thanks.

[jgournet]

@hameno : would you be able to progress this further after the comments ? This is a great feature that is direly missing

[hameno]

@hameno : would you be able to progress this further after the comments ? This is a great feature that is direly missing

Unfortunately I won't have capacity until next year. I found a workaround which works for us so this currently doesn't have priority

[jgournet]

May I ask what workaround you're using ? (right now, I'm just mounting the whole volume and hardcoding paths ... that will work, but if there's better, I wouldn't mind ;) )

[hameno]

(On mobile right now, so not exactly sure how it's called) I'm using the agent yaml template to adjust the Pod spec

[EricDales]

Hello, any chance this pull request will be finalized ?