junit-plugin icon indicating copy to clipboard operation
junit-plugin copied to clipboard
verified publisher icon jenkinsci

[JENKINS-69658] - failed-test.jelly javascript un-inlined.

Open Artmorse opened this issue 3 years ago • 3 comments

The issue You can find all the issue details here.

My updates I've moved the onclick calls from the failed-test.jelly file to the failureSummary.js one.

  • [x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • [x] Ensure that the pull request title represents the desired changelog entry
  • [x] Please describe what you did
  • [x] Link to relevant issues in GitHub or Jira
  • [x] Link to relevant pull requests, esp. upstream and downstream changes
  • [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

Artmorse avatar Oct 24 '22 17:10 Artmorse

@yaroslavafenkin Can you add the hacktoberfest-accepted label to this PR if it's seems good to you ? :blush:

Artmorse avatar Oct 31 '22 18:10 Artmorse

Hey @Artmorse, I tried reviewing this PR and followed Yaroslav's steps. I'm not encountering any errors, it's working as expected.

However, I noticed that we missed to report an occurrence of inline JS (summary.jelly#L34-L35) It's in a different class, but closely related to your changes, so if you're still willing to work on this topic, I'd be here to review it once more and help get it finally merged!

Kevin-CB avatar Mar 08 '24 16:03 Kevin-CB

hey @Kevin-CB, yes I'll make the changes and I'll ping you when it's done!

Artmorse avatar Mar 08 '24 16:03 Artmorse