junit-plugin icon indicating copy to clipboard operation
junit-plugin copied to clipboard

[GitHub Checks] When failed tests, add count of both passed and failed tests along with details of failed one

Open pkazi opened this issue 3 years ago • 7 comments

Dependencies

Feature Request

When junit report has any failed test, then GitHub check shows its details, but it does not show the count of total passed, failed and skipped tests.

It will be good to have count of all failed, passed and skipped tests on GH Checks.

pkazi avatar Aug 19 '21 07:08 pkazi

Can you add a bit more detail? do you mean in the check that you see on the main page of the PR?

it should show total if there's more than one failed.

can you add a screenshot?

timja avatar Aug 19 '21 09:08 timja

Yes , I am talking about the check we see on PR. When any tests are failed, it just shows details and stacktrace of failed test, but we can also show total number tests passed , failed and skipeed. image

pkazi avatar Aug 20 '21 07:08 pkazi

Doesn't it already do that?

https://github.com/jenkinsci/junit-plugin/pull/272/checks?check_run_id=3278730657

image

It may not do that when only 1 test failed.

If that's what happened there we should be able to make that clearer

timja avatar Aug 20 '21 09:08 timja

I havn't tested for more than 1 failures, but for sure it doesn't show up count of failed and passed tests

pkazi avatar Sep 03 '21 07:09 pkazi

I havn't tested for more than 1 failures, but for sure it doesn't show up count of failed and passed tests

it only skips that on a single failure, but it could be clearer

timja avatar Sep 03 '21 07:09 timja

So what you suggesting @timja ?

pkazi avatar Sep 03 '21 07:09 pkazi

Probably underneath the title just add the summary of failed/passed/skipped(if any)

timja avatar Sep 03 '21 07:09 timja