junit-plugin
junit-plugin copied to clipboard
jenkinsci
Add a list of all Skipped tests to the Test Result report
In a large test suite, it is useful to easily see a list of all skipped tests, as well as their age, i.e. for how many builds they've been skipped. Previously it was only possible to view all tests in a given class, then sort by result to view the Skipped tests in it.
Note that I've left the "Duration" column, as tests may sometimes be skipped during execution, but it might be better to remove it to reduce clutter - I could use some feedback on that.
Added an integration test which indeed helped to fix a logical error in getSkippedSince(). Thanks for your feedback!!
I like the change in general. One small thing I would like to see improved is making the list of skipped tests less significant in the UI. Collapsed by default? Moved to the very bottom? It is useful for sure but probably distracting most of the time...
@olivergondza Skipped tests table collapsed by default, accessible using a link placed at the bottom of the page. I've tried to stay consistent with the style on the summary page. Screenshots below:
Link is hidden and table is shown:
The skippedSince value is saved to XML (automatic saving of all fields, IIUC implemented by XStream2), but in most cases it's not computed before saving. See SuiteResultTest::testSuiteResultPersistence for implementation of saving test. For failedSince the freeze method makes sure that the field is computed before saving. If you add recomputeSkippedSinceIfNeeded() to CaseResult::freeze, saving will work, but it may lead to loading all the previous results from the disk. So recomputeSkippedSinceIfNeeded should fall back to previous build number if previous build failed but we don't know since when it's failing.
Also fixing the freeze method will cause a failure of the test testPreviousBuildNotLoaded from #117. Other way of testing for deep recursion is needed (maybe include 2 builds and make sure that we don't call getPreviousBuild on the older one?)
Is it possible, that this feature will be merged? :) I would like to use this feature as well :)
I'd love to see this feature available. What is lacking for a release? Basically lack of engagement? :-|
I'd love to see this feature available. What is lacking for a release? Basically lack of engagement? :-|
reviewing if https://github.com/jenkinsci/junit-plugin/pull/106#issuecomment-497928233 needs fixing and then resolving conflicts and testing it end 2 end. Basically needs someone (anyone) to pick it up and get it over the finish line.
Nice! There is demand :-) How could you have waited for so long !?!?12 ;-)
I would interested in the All Tests the least. How about making All Skipped Tests as second table, like in the original comment? At least configurable? If this is too much for here, I would create another issue.
Still here :) Sorry switched into a new role at work
Promise promise promise to complete it soon