jenkinsci
[JENKINS-73137] Adapt Jira plugin for jetty 12 EE8
see https://issues.jenkins.io/browse/JENKINS-73137
The goal of this PR is to adapt Jira-plugin for jetty 12 (EE8).
The most of the work is about adapting ProxyTestHandler and TestHandler classes to use Handler.Abstract from jetty12
🚨 Please review the guidelines for contributing to this repository.
- [X] Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
- [X] Ensure that the pull request title represents the desired changelog entry
- [X] Please describe what you did
- [X] Link to relevant issues in GitHub
- [X] Link to relevant pull requests, esp. upstream and downstream changes
- [X] Ensure you have provided tests - that demonstrates feature works or fixes the issue
Hi @rantoniuk, that would imply that this PR would need to sit around for a few more months before it could be merged, by which point the staffing for the current initiative would have ended, and the author of the PR may not necessarily be available to rebase the PR, deal with merge conflicts, address review feedback, etc. So I think there are two options:
- Accept this PR now in its current form, but delay a release of the Jira plugin until the October LTS release of Jenkins is available. This takes advantage of current staffing and the current state of this PR (passing CI build, no conflicts, etc)
- Block this PR and accept that since there may not be staffing to complete it later you will need to complete the work later yourself
Accept this PR now in its current form, but delay a release of the Jira plugin until the October LTS release of Jenkins is available. This takes advantage of current staffing and the current state of this PR (passing CI build, no conflicts, etc)
That's not an option, since this would conflict with the agreed LTS-only support policy. If we would merge this PR today, someone would need to do another PR later to fix/revert the non-LTS compatible changes - and that's why I would prefert this stays as a completed draft (i.e. green build) as it will easier to pick it up and update only the properties accordingly when new LTS line is available.
That's not an option
Understood, @rantoniuk. Does that imply you are accepting the second option; namely, to complete this work yourself at such a time as it is available in LTS?