jira-plugin icon indicating copy to clipboard operation
jira-plugin copied to clipboard

Extract release notes building from JiraSite

Open artkoshelev opened this issue 6 years ago • 10 comments

artkoshelev avatar Sep 04 '18 01:09 artkoshelev

Coverage Status

Coverage increased (+0.006%) to 52.885% when pulling d5d7421050b3b27adb11a5c3b1fe7eac52a48097 on artkoshelev:akoshelev/decomposing-jirasite-part-4 into f7a8dae8309b323531f923b1007772e11f04dafc on jenkinsci:master.

coveralls avatar Sep 04 '18 01:09 coveralls

Coverage increased (+0.006%)

🎆

artkoshelev avatar Sep 04 '18 01:09 artkoshelev

@oleg-nenashev so, should i create new branch for major release and do all the refactoring work there?

artkoshelev avatar Sep 28 '18 01:09 artkoshelev

@artkoshelev simply do not break backward compatibility :)

olamy avatar Sep 29 '18 12:09 olamy

I do not see a strict need for a breaking change here. A lot of refactoring could be done without breaking API. It's up to plugin maintainers, of course

oleg-nenashev avatar Oct 02 '18 11:10 oleg-nenashev

@artkoshelev would it work to leave a @Deprecated JiraSite.getReleaseNotesForFixVersion() and call inside it JiraCreateReleaseNotes.getReleaseNotesForFixVersion()?

rantoniuk avatar May 21 '19 20:05 rantoniuk

i'll give it a try

artkoshelev avatar May 23 '19 00:05 artkoshelev

@artkoshelev what do you think about rebasing this to feature/4.0 ?

rantoniuk avatar Apr 09 '20 08:04 rantoniuk

@warden sure, go for it

artkoshelev avatar Apr 20 '20 04:04 artkoshelev

ah, need to resolve confilcts

artkoshelev avatar Apr 20 '20 04:04 artkoshelev