jira-plugin icon indicating copy to clipboard operation
jira-plugin copied to clipboard

Move progressMatchingIssues out of JiraSite

Open artkoshelev opened this issue 6 years ago • 7 comments

artkoshelev avatar Jul 08 '18 03:07 artkoshelev

Coverage Status

Coverage increased (+0.3%) to 53.656% when pulling 50abd59f2345a63cfa8c0d43200d39305017c53e on artkoshelev:akoshelev/decomposing-jirasite-part-3 into 0beb22c8bda5a8ebc99e21e46cbd49c645826c8c on jenkinsci:master.

coveralls avatar Jul 08 '18 03:07 coveralls

I like this approach for the decomposing and cleanup part :) @artkoshelev are you still up for it? @olamy for the backward compatibility, how about scheduling it for 4.x and do a @Deprecated in a separate PR for the affected method?

rantoniuk avatar Apr 30 '19 10:04 rantoniuk

It would be nice to do a major release removing all code marked @Deprecated

artkoshelev avatar May 01 '19 03:05 artkoshelev

@artkoshelev why? maybe it's sad but you can break few people so we should avoid that.... That's the life of opensource project... anyway this pr need to be rebased due to changes in master

olamy avatar May 01 '19 04:05 olamy

it should be fine to break backward-cap on major releases, you can't keep legacy code forever, it's becoming more and more harder to maintain

artkoshelev avatar May 01 '19 06:05 artkoshelev

I'm a believer of the approach that if we want the OSS projects to be alive,non-buggy and up2date with recent (here recent meaning <3y) standards, then we should regularly clean up the code. That's why @Deprecated was created, it's up to us though to define the release cycles policy and when to clean it up I guess.

rantoniuk avatar May 07 '19 22:05 rantoniuk

@artkoshelev what do you think about rebasing this to feature/4.0 ?

rantoniuk avatar Apr 09 '20 08:04 rantoniuk