Remove hierarchy-related sidebar links

[janfaracik]

Small PR to remove hierarchal sidebar links from every page that I could find them on. For context, the links removed are links such as 'Back to Dashboard' and 'Up'. We want to cut down on the amount of items in the sidebar and all these links do is duplicate breadcrumb items.

Before

After

⚠️ Updated 16:30 25/07/22

One-column layouts now appear centered + have their max-width increased, which I think helps make the layout easier to use + brings back the familiarity of the form not being on the far left of the screen.

Let me know what y'all think 👍

Proposed changelog entries

• Remove hierarchal sidebar links

Proposed upgrade guidelines

N/A

Submitter checklist

• [ ] (If applicable) Jira issue is well described
• [ ] Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change) and are in the imperative mood. Examples
  • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
• [ ] Appropriate autotests or explanation to why this change has no tests
• [ ] New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadoc, as appropriate.
• [ ] New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO") if applicable.
• [ ] For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@jenkinsci/sig-ux

Maintainer checklist

Before the changes are marked as ready-for-merge:

• [ ] There are at least 2 approvals for the pull request and no outstanding requests for change
• [ ] Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
• [ ] Changelog entries in the PR title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood
• [ ] Proper changelog labels are set so that the changelog can be generated automatically
• [ ] If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
• [ ] If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[daniel-beck]

Global security Global Tools

They'll probably have the new form layout soon, no?

[timja]

Global security Global Tools

They'll probably have the new form layout soon, no?

Possibly but for now they seem very unbalanced to me

[timja]

one-column layouts also seem off =/.

Plugin manager (which has stayed as 2 column currently) at least should be easy to fix by the existing PR that's open

[daniel-beck]

Maybe you should mention in the PR header that this change only affects Freestyle jobs 😜 I installed the PR several times until I noticed that there is duplicated code for Pipelines in the workflow plugins that obviously is not affected by your change.

A recurring and not at all irrelevant problem for many of these PRs, without clear documentation and/or downstream PRs adapting plugins, Jenkins just becomes more inconsistent, and the benefits of such changes won't be seen by many users.

[timja]

A recurring and not at all irrelevant problem for many of these PRs, without clear documentation and/or downstream PRs adapting plugins, Jenkins just becomes more inconsistent, and the benefits of such changes won't be seen by many users.

Can you file a downstream PR please @janfaracik?

[timja]

ATH results need checking (3 failing currently): https://github.com/jenkinsci/acceptance-test-harness/pull/869

[github-actions[bot]]

Please take a moment and address the merge conflicts of your pull request. Thanks!

[timja]

checkstyle issue and ATH to sort

[timja]

ATH is sorted in https://github.com/jenkinsci/acceptance-test-harness/pull/869

---

/label ready-for-merge

---

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

[daniel-beck]

Any plans to adapt the most popular plugins to this new "style guide"? Is there developer documentation for this change?

[janfaracik]

Any plans to adapt the most popular plugins to this new "style guide"? Is there developer documentation for this change?

Will do 👍 There's some guidance in draft here https://github.com/jenkinsci/design-library-plugin/pull/90

[basil]

Causes JENKINS-69370 (CC @janfaracik). This regression affects the connection of inbound agents. In the absence of a verified fix by the end of the week, I plan to revert this PR prior to next week's release of 2.365.