Added gitpod.Dockerfile

[iqbalrohail]

trafficstars

Accommodates Java 17 requirement

• [X] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• [X] Ensure that the pull request title represents the desired changelog entry
• [X] As this plugin is tested with java 17 #98 , I have added a .gitpod.Dockerfile , which will allow developers to easily compile/test the plugin with JDK-17 while keeping the default JDK-11.

[jmMeessen]

Hello @iqbalrohail ,

Thank you for your pull request. Could you explain/elaborate in the PR description what is the problem you are trying to solve with this PR? If I remember well the default Gitpod image (at least 2 months ago) defaulted to a Java 11. Introducing a dockerfile adds a lot of delay in starting up the environment.

I am further puzzled because you are not including the dockerfile in the gitpod configuration.

[iqbalrohail]

yes there should be configurations for this in gipod.yml as well

[iqbalrohail]

it will use an updated Gitpod docker image (when using a non-default JDK or tools)

[jmMeessen]

Can you please elaborate ? I don't understand what you are trying to achieve.

Especially as you are resetting the default JDK to JDK11 ?

My guess is that you want to give the opportunity to developers to easily compile/test the plugin with the bleeding-edge JDK17 (as it is now validated in the Jenkinsfile, see #98 ), while keeping the default JDK to 11. If this is the case, it would be worthwhile to add a note in a dedicated doc file (or start a CONTIBUTING.md doc) how to proceed. WDYT?

[iqbalrohail]

As i checked that this can be compiled/test with jdk17, so I just added the configurations to check/test this with JDK 17 in a easy way but the default jdk is not changing , it will be jdk 11

[jmMeessen]

So my guess was right. Very good initiative, @iqbalrohail.

As you have seen, the explanation of what you do and its intend is critical (if you want people to benefit from your work).

I believe that we need to clarify this at least in the PR description. How about adding a note about this in a special doc file, explaining how to switch from JDK when in Gitpod?

[iqbalrohail]

I have clarified this in PR description

[jimklimov]

And how is the eclipse style file change (formatter lines) related to this? :)

[iqbalrohail]

@jimklimov sorry i didn't have any idea on this ..

[MarkEWaite]

Closing because Gitpod is changing their business model.