helm-charts
helm-charts copied to clipboard
add jcasc auto reload sidecar resources
What does this PR do?
This PR updates the values summary documentation to include a reference to how to set resource requests and limits for the configAutoReload. Exposing the resource limits and requests for the sidecar allows them to be set to the same value, which allows the whole Pod to be granted a "Guaranteed" QoS class. The helmchart already supports this, though it wasn't reflected in the docs already.
If you modified files in the ./charts/jenkins/
directory, please also include the following:
### Submitter checklist
- [x] I bumped the "version" key in `./charts/jenkins/Chart.yml`.
- [x] I added a new changelog entry to `./charts/jenkins/CHANGELOG.md`.
- [x] I followed the [technical requirements](https://github.com/jenkinsci/helm-charts/blob/main/CONTRIBUTING.md#technical-requirements).
Special notes for your reviewer
I was only trying to make the documentation consistent, since the other containers specified in values.yaml
had references to their associated resources in VALUES_SUMMARY.md
. I'll close the PR if you're not going to accept someone offering to improve the docs.
Would you accept a change adding matching resource requests
and limits
for the auto config reload container?
I was only trying to make the documentation consistent, since the other containers specified in
values.yaml
had references to their associated resources inVALUES_SUMMARY.md
. I'll close the PR if you're not going to accept someone offering to improve the docs.
I see, happy to take the PR, would you be able to resolve the conflicts please?