helm-charts
helm-charts copied to clipboard
Added security spec to jcasc values
Signed-off-by: Miles Wilson [email protected]
What this PR does / why we need it
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)
- fixes #684
Special notes for your reviewer
Checklist
- [X] DCO signed
- [X] Chart Version bumped
- [X] CHANGELOG.md was updated
had to add some extensive if logic to include the original security settings in a variety of cases. Seems like this is an issue in helm 3.8.2
but not 3.9
, which is interesting
Edit: This is due to differences in Go versions, as detailed here: https://github.com/helm/helm/pull/10806
Simplified logic to let the apiToken default live in the values.yaml
file. Added info about the new field to the values file as well as the values summary readme.
Adding unit tests for two cases:
- The security section is added to, but apiToken is not changed from the default
- apiToken is modified in downstream values using the security section The third implicit case it that unspecified security retains legacy behavior, which is confirmed by the other tests passing