helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

Published 20 hours ago • verified publisher icon jenkinsci

jenkins-test pod definition issues

Open andy-dws opened this issue 1 year ago • 2 comments

Just a couple of observations from running this chart in a corporate environment with no internet access and a private repository with binary authorization enabled (i.e. digests are mandatory, label tags are forbidden).

https://github.com/jenkinsci/helm-charts/blob/17fbf8f1566e139a96ff3f3084eab8da1532de3d/charts/jenkins/templates/tests/jenkins-test.yaml#L20

The above should be configurable.

https://github.com/jenkinsci/helm-charts/blob/17fbf8f1566e139a96ff3f3084eab8da1532de3d/charts/jenkins/templates/tests/jenkins-test.yaml#L34

The above should be written in the same style as the main statefulset so that digests are possible.

andy-dws avatar Aug 11 '22 13:08 andy-dws

PR welcome :)

timja avatar Aug 11 '22 13:08 timja

Hello @andy-dws I am new to Jenkins open source and would like to work on this issue, am I editing line 20 image: "bats/bats:1.2.1" to line 34 image: {{ .Values.controller.image }}:{{ .Chart.AppVersion }}-{{ .Values.controller.tagLabel }} Thanks

ismaelsadeeq avatar Sep 21 '22 22:09 ismaelsadeeq

Hi @timja! I would love to work on this issue if no one else is, looking for a good first issue to get involved with the Jenkins community! We use it as our primary CI/CD at our company and also heavily use helm for a majority of our application deployments. Read through the contributing documentation and I should be set to open pull request in the next few days. I just have two questions after reading through the helm charts:

  1. Should the VALUES_SUMMARY.md be updated to include a Unit Test section now that it will be configurable?
  2. What format would be best to pass in the configurable values: in the base values.yaml file, have an additional values.yaml file under unittests directory then updating the CONTRIBUTING.md to pass in multiple values files, or simply use --set commands for when the helm unittests are executed.

Thanks and hope you have a great day!

elmsdata avatar Feb 22 '23 03:02 elmsdata

Should the VALUES_SUMMARY.md be updated to include a Unit Test section now that it will be configurable

May as well probably at the very bottom

What format would be best to pass in the configurable values

Base values.yaml sounds fine to me

timja avatar Feb 22 '23 09:02 timja

Wonderful, thanks for clarifying! Should have the pull request open tomorrow and hope you have an amazing Friday!

elmsdata avatar Feb 24 '23 02:02 elmsdata