helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

Published 20 hours ago • verified publisher icon jenkinsci

update relablings for servicemonitor resource

Open dmitriy-lukyanchikov opened this issue 2 years ago • 5 comments

What this PR does / why we need it

fix relabelings for servicemonitor, added toyaml because its a list of maps not the single value

Which issue this PR fixes

Special notes for your reviewer

Checklist

  • [X] DCO signed
  • [X] Chart Version bumped
  • [X] CHANGELOG.md was updated

dmitriy-lukyanchikov avatar May 27 '22 09:05 dmitriy-lukyanchikov

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

stale[bot] avatar Sep 21 '22 05:09 stale[bot]

What would be required for this PR to be merged? In our company, we would appreciate the change to add relabelings to the ServiceMonitor

igorzamyslov avatar Oct 31 '22 07:10 igorzamyslov

A unit test and conflicts resolving, apologies for missing this PR

timja avatar Oct 31 '22 08:10 timja

Hi @dmitriy-lukyanchikov , was curious on the status on this PR. Would love to see this merged, let me know if I could help out.

dhhuynh2 avatar Dec 09 '22 17:12 dhhuynh2

this looks like to be fixed on main branch, so can you close it?

piotrwielgolaski-tomtom avatar Jun 08 '23 10:06 piotrwielgolaski-tomtom