hashicorp-vault-plugin icon indicating copy to clipboard operation
hashicorp-vault-plugin copied to clipboard

Removed 1 unnecessary stubbing in AbstractVaultTokenCredentialWithExpirationTest.java

Open ARUS2023 opened this issue 8 months ago • 0 comments

Testing done

### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [ ] Link to relevant issues in GitHub or Jira
- [ ] Link to relevant pull requests, esp. upstream and downstream changes
- [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

In our analysis of the project, we observed that 1 unnecessary stubbing which stubbed getAuthClientToken method in setUp is created but is never executed by 2 tests AbstractVaultTokenCredentialWithExpirationTest.shouldFetchNewTokenIfExpired, AbstractVaultTokenCredentialWithExpirationTest.shouldExpireTokenImmediatelyIfExceptionFetchingTTL.

Unnecessary stubbings are stubbed method calls that were never realized during test execution. Mockito recommends to remove unnecessary stubbings (https://www.javadoc.io/doc/org.mockito/mockito-core/latest/org/mockito/exceptions/misusing/UnnecessaryStubbingException.html).

We propose below a solution to remove the unnecessary stubbings.

ARUS2023 avatar Oct 18 '23 03:10 ARUS2023