hashicorp-vault-plugin
hashicorp-vault-plugin copied to clipboard
Removed 2 unnecessary stubbings in FolderIT.java
Testing done
### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [ ] Link to relevant issues in GitHub or Jira
- [ ] Link to relevant pull requests, esp. upstream and downstream changes
- [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue
In our analysis of the project, we observed that
2 unnecessary stubbings which stubbed getData
method and read
method in mockVaultAccessor
are created but are never executed by the test FolderIT.jobInFolderShouldNotBeAbleToAccessCredentialsScopedToAnotherFolder
.
Unnecessary stubbings are stubbed method calls that were never realized during test execution. Mockito recommends to remove unnecessary stubbings (https://www.javadoc.io/doc/org.mockito/mockito-core/latest/org/mockito/exceptions/misusing/UnnecessaryStubbingException.html).
We propose below a solution to remove the unnecessary stubbings.