hashicorp-vault-plugin icon indicating copy to clipboard operation
hashicorp-vault-plugin copied to clipboard

Refactoring token expiry check

Open ash1425 opened this issue 3 years ago • 0 comments

We had introduced additional abstract class to add token expiry awareness in last release. This made it 3 levels of abstract classes.

After looking into it closely, I think probably it's a good idea to make token expiry aware a default behaviour - as this is useful in all the cases except plain token based secret.

About duplication of token expiry checking logic in JCasC and Credentials - I think this needs a bigger refactoring. We should extract Vault Authentication mechanism in a common place and it should be used by both credentials and JCasC secrets code.

ash1425 avatar Dec 25 '20 00:12 ash1425