gradle-plugin icon indicating copy to clipboard operation
gradle-plugin copied to clipboard

Convert Plugin to be compatible with Jenkins pipeline

Open funtastix opened this issue 6 years ago • 6 comments

  • DryRun was removed for this purpose and SimpleBuildStep implemented instead
  • Simple usage example: "gradle tasks: 'clean assembleDebug', useWrapper: true"
  • Works with Snippet Generator (which adds additional/unnecessary parameters)
  • This enables gradle (wrappers) to be used easily cross-platform without scripts needed

funtastix avatar Oct 03 '18 05:10 funtastix

Thanks for the contribution! Can you fix the tests?

jvz avatar Oct 03 '18 17:10 jvz

I will look into them. There seems to be additional tests running as all test had passed on my build machine.

funtastix avatar Oct 03 '18 18:10 funtastix

The test failures appear to be on Windows only, so that could be part of the problem.

jvz avatar Oct 03 '18 19:10 jvz

This is what is confusing as I build on windows. I will hopefully figure it out.

funtastix avatar Oct 03 '18 19:10 funtastix

@jvz I tracked the failures down to a parameter passing ending in '\'. I don't understand what this needs to look like and how my changes would have affected those tests. The parameter encoding is done via Jenkins util classes. I will try to get a comparison with and without my commits. It may be a good idea to add a new parameter test: Param="X;YZ\"

funtastix avatar Oct 06 '18 20:10 funtastix

Almost sounds like the test failure might be unrelated then?

jvz avatar Oct 08 '18 15:10 jvz

@funtastix I'll be closing the PR, given that there hasn't been any recent activity. Is the PR still interesting? If yes, please open a new one based on current main. Thank you!

wolfs avatar Oct 18 '22 09:10 wolfs