golang-plugin icon indicating copy to clipboard operation
golang-plugin copied to clipboard

Modernize to latest versions supported by Java 8

Open sghill-rewrite opened this issue 1 year ago • 2 comments

Hi!

This PR aims to modernize tooling and move this plugin closer to the recommended Jenkins baseline version without making the change too big. If this goes well, I can follow up with a subsequent PR to modernize further.

This PR was generated with an OpenRewrite recipe on Moderne.io.

index.jelly is a required file with the newer tooling.

I decided to remove the properties for jenkins.bom.artifactId and jenkins.bom.version because I thought it would simplify maintenance. SourceGraph showed this as the only repository that defines these properties.

Testing done

Ran mvn clean verify.

### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [x] Link to relevant issues in GitHub or Jira
- [x] Link to relevant pull requests, esp. upstream and downstream changes
- [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

sghill-rewrite avatar Jul 15 '23 02:07 sghill-rewrite

@orrc would you be able to look at this modernization PR or recommend someone who could?

sghill avatar Jul 25 '23 21:07 sghill

@jenkinsci/golang-plugin-developers are you able to take a look at this modernization PR? There are some other nice things we could do as well to reduce the burden for maintainers - like CD releases that happen entirely from GitHub Actions.

sghill avatar Aug 21 '23 03:08 sghill