gitlab-plugin icon indicating copy to clipboard operation
gitlab-plugin copied to clipboard

Question: Missing Build Parameters for Replay

Open almozavr opened this issue 7 years ago • 7 comments

Context

  • Gitlab plugin version: > 1.2.0
  • Jenkins version: X.Y.Z > 2.3
  • Job type: Pipeline

Problem description

Due to docs gitlab sets hook data via environment and not through build parameters -> it makes replay meaningless which is very disturbing in terms of debugging. Could you explain why it is not possible to use build parameters? Github plugin still does it and works as intended. Thanks!

almozavr avatar Nov 15 '17 16:11 almozavr

@almozavr can you elaborate on why this makes replay "meaningless?" Are you referring to the replay feature of Pipelines?

The reason this change was made is explained here: https://jenkins.io/blog/2016/05/11/security-update/ I don't know how the GitHub plugin would still be using parameters at this point. It would only work if you overrode the security fix, so I suspect that is not really the case.

omehegan avatar Jan 17 '18 00:01 omehegan

@omehegan by "Replay" I mean job feature (http://take.ms/z4HB8) It's unusable with gitlab plugin because those environment params gitlab passes to concrete job on trigger are not available (and are missing) during replay

almozavr avatar Jan 17 '18 08:01 almozavr

@almozavr OK, I will look into this, it sounds like a bug.

omehegan avatar Jan 17 '18 23:01 omehegan

2 ½ years later this bug still exists. Whats the status on this matter?

a-hab avatar Apr 24 '20 09:04 a-hab

3 year later, any advance?

rafabc avatar Feb 05 '21 11:02 rafabc

This MR "might" help : https://github.com/jenkinsci/gitlab-plugin/pull/898/files

Kimamisa avatar Feb 05 '21 13:02 Kimamisa

It keeps happening, do you know if it is going to be fixed? it is a problem because from GitLab you can't force a build without doing an extra commit either.

Themesaul avatar Mar 14 '23 10:03 Themesaul