github-plugin icon indicating copy to clipboard operation
github-plugin copied to clipboard

[JENKINS-65935] GitHub plugin invalid issue forwarding

Open jenkins-infra-bot opened this issue 4 years ago • 2 comments

If you close an issue or pull request via a commit message on GitHub (see GitHub linking issues for a full list of messages supported), the link created used at the "Changes" tab invalid.
It uses the following pattern: https://github.com///issues//find
The appended /find is out of place and will lead to a 404 on GitHub, removing it makes the link valid again.
I attached a screenshot, clicking on "Closes #..." will lead to the invalid URL described above. Making it valid requires removing the /find at the end.


Originally reported by jthomas, imported from: GitHub plugin invalid issue forwarding
  • assignee: lanwen
  • status: Open
  • priority: Minor
  • component(s): github-plugin
  • label(s): core, github-plugin, plugin
  • resolution: Unresolved
  • votes: 0
  • watchers: 3
  • imported: 2025-12-08
Raw content of original issue

If you close an issue or pull request via a commit message on GitHub (see GitHub linking issues for a full list of messages supported), the link created used at the "Changes" tab invalid. It uses the following pattern: https://github.com/<org|user>/<repo>/issues/<issue id>/find The appended /find is out of place and will lead to a 404 on GitHub, removing it makes the link valid again. I attached a screenshot, clicking on "Closes #..." will lead to the invalid URL described above. Making it valid requires removing the /find at the end.

environment
Jenkins 2.293<br/>
GitHub plugin 1.33.1
1 attachment

jenkins-infra-bot avatar Jun 19 '21 10:06 jenkins-infra-bot

kon:

The /find suffix seems to come from GithubLinkAnnotator.java, where it has been since 2009. If it is removed, then GithubLinkAnnotatorTest.java should be updated as well.

jenkins-infra-bot avatar Oct 19 '21 13:10 jenkins-infra-bot

notmyfault:

This may also be expanded to the keywords closing issues.

jenkins-infra-bot avatar Oct 19 '21 14:10 jenkins-infra-bot