github-plugin icon indicating copy to clipboard operation
github-plugin copied to clipboard

[JENKINS-37015] Aborted builds are reported as pending to Github

Open jenkins-infra-bot opened this issue 9 years ago • 0 comments

Result.ABORTED is not supported by DefaultStatusResultSource. I've tried to implement a fix here https://github.com/jenkinsci/github-plugin/pull/133. However, it doesn't appear that Result.ABORTED is going to work properly with the current isBetterThanOrEqual logic because ABORTED has the greatest value.

As a general note, I'm also confused why this isBetterThanOrEqualTo logic was used in the first place. It seems like a mapping of Result to GHCommitStatus would suffice.


Originally reported by kpike, imported from: Aborted builds are reported as pending to Github
  • assignee: lanwen
  • status: Open
  • priority: Minor
  • component(s): github-plugin
  • resolution: Unresolved
  • votes: 1
  • watchers: 1
  • imported: 2025-12-08
Raw content of original issue

Result.ABORTED is not supported by DefaultStatusResultSource. I've tried to implement a fix here https://github.com/jenkinsci/github-plugin/pull/133. However, it doesn't appear that Result.ABORTED is going to work properly with the current isBetterThanOrEqual logic because ABORTED has the greatest value.

As a general note, I'm also confused why this isBetterThanOrEqualTo logic was used in the first place. It seems like a mapping of Result to GHCommitStatus would suffice.

jenkins-infra-bot avatar Jul 27 '16 22:07 jenkins-infra-bot