[JENKINS-60738] Fix global configuration submission from UI

[Dohbedoh]

Fixes JENKINS-60738 caused by changes introduced in https://github.com/jenkinsci/github-plugin/pull/221.

Databinding of hookUrl is not working properly, per my understanding because the DataboundSetter setHookUrl(String hookUrl) accepts a String but the field is a URL. While adding a public void setHookUrl(URL hookUrl) might solve some of the problem, then there is yet another issue that disabling the Specify another hook URL for GitHub configuration checkbox does not remove the hook URL at all... that seems wrong.

So the propose fix:

• handle the binding and the optional property state in the configure(StaplerRequest req, JSONObject json)
• reactivate and adjusted the global configuration UI tests

• [x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• [x] Ensure that the pull request title represents the desired changelog entry
• [x] Please describe what you did
• [x] Link to relevant issues in GitHub or Jira
• [x] Link to relevant pull requests, esp. upstream and downstream changes
• [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

[jglick]

While this sounds fine as a hotfix, the proper fix would be to delete all the overrides and special cases handling and fix the form to use normal databinding by convention.

[jtnord]

@KostyaSha are you ok with this as the active maintainer of this plugin?

[jrtc27]

What's the status of this? I've just run into this with our own instance.

[yahooguntu]

I have the same issue; as a workaround I've been adding <hookUrl> directly to github-plugin-configuration.xml, but unfortunately it's cleared out when I save/apply System settings in the web UI.

[jrtc27]

I have the same issue; as a workaround I've been adding <hookUrl> directly to github-plugin-configuration.xml, but unfortunately it's cleared out when I save/apply System settings in the web UI.

If you edit the config file and restart so it has the updated value in memory then the UI should show the correct setting and not clobber it on save.

[franknarf8]

Can this be merged soon? I've just noticed this open PR after implementing the same fix and opening another PR : https://github.com/jenkinsci/github-plugin/pull/375

Feel free to close the other PR

@KostyaSha @jglick

[jglick]

(I am not a maintainer)