github-plugin icon indicating copy to clipboard operation
github-plugin copied to clipboard

Fix JENKINS-54249

Open bgaillard opened this issue 5 years ago • 0 comments

This PR fixes the following issue https://issues.jenkins-ci.org/browse/JENKINS-54249.

Few additional notes :

  • The code update the git plugin to version 4.0.0-rc to have the BuildDetails class (see comments associated to this commit for more details ttps://github.com/jenkinsci/git-plugin/commit/07cfa5ddef698838b01d4214915f98d4e902c0f8#diff-6cb4dc50342af417dc66c68b45c48fb1)
  • I removed the scm-api dependency in the pom.xml because its a transitive dependency of the git Jenkins plugin
  • Usage of the BuildData class has been removed as much as possible. So now we prefer BuildDetails.

This is the first time I update a Jenkins plugin so do not hesitate to help me improve this before merging.


This change is Reviewable

bgaillard avatar Jun 15 '19 15:06 bgaillard