github-checks-plugin icon indicating copy to clipboard operation
github-checks-plugin copied to clipboard

Change default behaviour of "Suppress progress updates in job check"

Open ventojna opened this issue 3 years ago • 3 comments

Change default behaviour of "Suppress progress updates in job check" to reduce GitHub API call because of the rate limit and add a global config for this setting. We tried to enforce the the global setting but we need some advice about Jelly on this

thx to @meiswjn

  • [x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • [x] Ensure that the pull request title represents the desired changelog entry
  • [x] Please describe what you did
  • [ ] Link to relevant issues in GitHub or Jira
  • [ ] Link to relevant pull requests, esp. upstream and downstream changes
  • [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

ventojna avatar Oct 18 '22 14:10 ventojna

Hi Tim, Thanks for your fast response!

We are using GitHub Cloud, so we cannot disable the rate limit. Our controller is used by many different teams and they often share the same rate limit.

If I am not mistaken, batching the calls would likely not help here, since the feature is about constant status updates on how far the build job is - if we batch those, they would be delayed and don't make any sense anymore anyways, if you understand what I mean.

meiswjn avatar Oct 19 '22 07:10 meiswjn

If I am not mistaken, batching the calls would likely not help here, since the feature is about constant status updates on how far the build job is - if we batch those, they would be delayed and don't make any sense anymore anyways, if you understand what I mean.

It depends on how often the updates currently are being sent. if they were grouped to send no more often than 1-2 minutes per job then that may alleviate it while still being fresh enough to being useful.

timja avatar Oct 19 '22 08:10 timja

Do you mean batching the calls from multiple jobs?

Since it is currently already possible to disable the progress updates on a per-job level, it would be nice to have the feature of this PR to change the default value globally :)

meiswjn avatar Oct 19 '22 08:10 meiswjn