git-plugin icon indicating copy to clipboard operation
git-plugin copied to clipboard

Published 20 hours ago • verified publisher icon jenkinsci

JENKINS-65315: SubmoduleOption: resolve env vars in reference path

Open lmife opened this issue 1 year ago • 3 comments

JENKINS-65315 - Resolve environment variables in SubmoduleOption reference path

On contrary to Freestyle projects' getEnvironment, WorkflowRun.getEnvironment doesn't provide node-specific environment variables as it can have multiple node blocks in parallel. So I suggest to pick up envvars just in place.

See also https://github.com/jenkinsci/git-plugin/pull/575 where this had already been done for CloneOption

Checklist

  • [x] I have read the CONTRIBUTING doc
  • [x] I have referenced the Jira issue related to my changes in one or more commit messages
  • [x] Unit tests pass locally with my changes
  • [x] No Javadoc warnings were introduced with my changes
  • [x] No spotbugs warnings were introduced with my changes
  • [x] I have interactively tested my changes

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)

lmife avatar Feb 23 '24 07:02 lmife

Tests are failing, but I don't know what to do about the "Jenkins.instance is missing. Read the documentation of Jenkins.getInstanceOrNull to see what you are doing wrong.". Even after reading the documentation of Jenkins.getInstanceOrNull I have no clue. If somebody can point me to the right direction this would be very helpful.

lmife avatar Feb 23 '24 13:02 lmife

not good

can you please give a more in depth explanation? Is the change not working for you?

lmife avatar Apr 15 '24 11:04 lmife

Unfortunately, some tests are still failing after merging the latest master into my branch. I still do not understand what the system is trying to tell me and how to fix the issues. Can anybody assist me here and point me to the right direction? It would be very much appreciated.

lmife avatar Jul 04 '24 12:07 lmife