git-client-plugin icon indicating copy to clipboard operation
git-client-plugin copied to clipboard

Published 20 hours ago • verified publisher icon jenkinsci

[JENKINS-62579] Use windows system temp dir more often

Open MarkEWaite opened this issue 5 years ago • 0 comments

JENKINS-62579 - Use windows system temp dir for non-Latin-1 workspaces

If the Windows temporary directory path contains Cyrillic characters, command line git fails to find the files needed for SSH and HTTP/HTTPS authentication. Git plugin 4.0.0 and later have intentionally chosen to place credentials related temporary files near the Jenkins workspace when the path name allows it. This is another case where the path name does not allow it.

Most readily affects Freestyle projects, since they are able to use a Cyrillic character in the job name easily. Multibranch Pipeline jobs seem to correctly "hide" the Cyrillic characters when creating the workspace directory name.

Checklist

  • [x] I have read the CONTRIBUTING doc
  • [x] I have referenced the Jira issue related to my changes in one or more commit messages
  • [ ] I have added tests that verify my changes
  • [x] Unit tests pass locally with my changes
  • [x] I have added documentation as necessary
  • [x] No Javadoc warnings were introduced with my changes
  • [x] No spotbugs warnings were introduced with my changes
  • [ ] I have interactively tested my changes

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)

Further comments

Do not merge this draft pull request until automated tests have been included that duplicate the problem and interactive tests have confirmed the code change resolves the issue.

MarkEWaite avatar Jun 07 '20 05:06 MarkEWaite