ghprb-plugin icon indicating copy to clipboard operation
ghprb-plugin copied to clipboard

Add support for Workflows when loading comment files

Open nosmo opened this issue 6 years ago • 11 comments

When a job is initiated via the pipeline plugin, the Run object is no longer an instance of Build, it becomes an instance of WorkflowRun. This means that the current logic for finding comment files on remote workers does not find the comment file when using a pipeline. Additionally, WorkflowRuns are more complex objects and they can have multiple associated workspaces.

This PR introduces support for finding the files on the remote workspaces.

This change does not allow for seamless discovery of the files in workspaces if multiple nodes are used, and users will be required to stash and unstash as is appropriate if using remote nodes, but I've included a documentation note to explain this.

(This is a repost of #682 - I was requested to re-file)

nosmo avatar Nov 20 '18 14:11 nosmo

looks like the same result :( Did you merge master into your branch? maybe the most recent merges don't play nice with your branch?

Kentalot avatar Nov 21 '18 18:11 Kentalot

Looks like a rebase against master fixed it - not entirely sure why as tests look the same locally.

nosmo avatar Nov 22 '18 14:11 nosmo

Yay! @samrocketman looks like this one can be approved and merged. Tests seem fixed!

Kentalot avatar Nov 24 '18 08:11 Kentalot

@nosmo seems the git author for your commits is off. Do you need to update the author? Otherwise your GitHub account would not be counted among the contributors.

samrocketman avatar Dec 07 '18 23:12 samrocketman

@samrocketman good catch - I've changed the author in commits.

nosmo avatar Dec 12 '18 13:12 nosmo

now failed again haha

Kentalot avatar Jan 19 '19 00:01 Kentalot

Rebased and ran again, looks like they're passing.

nosmo avatar Jan 23 '19 13:01 nosmo

Any updates on this?

redwyre avatar Jul 26 '19 20:07 redwyre

Any update on this? Not able to use Comment file feature for Pipeline jobs which runs on slave nodes.

pkazi avatar Sep 27 '20 19:09 pkazi

Any update on this?

fr-kqkq avatar Dec 08 '20 09:12 fr-kqkq

Any updates?

TheSAS avatar Feb 18 '21 20:02 TheSAS