ghprb-plugin icon indicating copy to clipboard operation
ghprb-plugin copied to clipboard

Published 20 hours ago • verified publisher icon jenkinsci

Handle (un)labeled pull request hooks

Open Rechi opened this issue 6 years ago • 17 comments

Without handling the unlabeled hook jenkins still things the ignore label is present (#431) and skips building the PR. This might also fix #496.

Rechi avatar Mar 04 '18 09:03 Rechi

I assume you made a manual test of this?

bjoernhaeuser avatar Mar 04 '18 19:03 bjoernhaeuser

Although this solved the issue with removing blacklist labels, I just noticed that adding new labels to a PR after it was merged, caused it to be rebuild. I'll investigate a fix for that behaviour and update the PR.

see http://jenkins.kodi.tv/view/Automation/job/BuildMulti-PR/7295/ http://jenkins.kodi.tv/view/Automation/job/BuildMulti-PR/7296/

Rechi avatar Mar 05 '18 06:03 Rechi

Thanks!

bjoernhaeuser avatar Apr 06 '18 19:04 bjoernhaeuser

any update on this?

xwartz avatar Apr 30 '18 03:04 xwartz

Would love to get this change in. List of GitHub labels for which the build should not be triggered works but if labels are removed, builds still won't be triggered

Kalvin126 avatar Sep 13 '18 19:09 Kalvin126

@Rechi do you have an update on your issue?

bjoernhaeuser avatar Oct 21 '18 17:10 bjoernhaeuser

Also wondering when it will be merged?

therapy-lf avatar Nov 29 '18 17:11 therapy-lf

Sorry for the extra comment, but I'm really interested in having this change merged.

droca avatar Feb 28 '19 15:02 droca

+1 to this feature as well!

s1113950 avatar Mar 04 '19 18:03 s1113950

It looks good enough to me, even if there are some edge cases that might still not be covered, most of them are.

droca avatar Mar 05 '19 08:03 droca

+1 too

silva96 avatar Jun 26 '19 16:06 silva96

@Rechi I tried to build your edits and added the plugin manually to jenkins but still changes labels couldn't be triggered by jenkins

DinaGamalMahmoud avatar Nov 11 '19 07:11 DinaGamalMahmoud

Hi all, is there anything I can do to help move this forward? We'd love to utilize this feature in our workflow. Thanks!

l3ender avatar Mar 16 '20 23:03 l3ender

@janinko I really would like to get your opinion on this PR

My team strongly relies on label events to trigger builds. Can you consider accepting and merging the pull request as it is (with conflict fixes)? I would prefer not to fork your project in order to get this functionality working.

If the pull request needs any fixes, I would be happy to take care of them.

mattymo avatar Dec 11 '20 10:12 mattymo

Even though I'm the original author of this plugin, I'm not its maintainer anymore for a long time. If there are no active maintainer I suggest to look at https://www.jenkins.io/doc/developer/plugin-governance/adopt-a-plugin/

janinko avatar Dec 11 '20 11:12 janinko

@janinko I really appreciate you getting back about this! It's understandable if you don't want to maintain the plugin.

@bjoernhaeuser Are you also no longer an active maintainer?

mattymo avatar Dec 11 '20 12:12 mattymo

@janinko In the off chance that this PR is acceptable, I'm going to file a duplicate PR that addresses comments and fixes the merge conflict.

mattymo avatar Dec 11 '20 12:12 mattymo