ghprb-plugin icon indicating copy to clipboard operation
ghprb-plugin copied to clipboard

Published 20 hours ago • verified publisher icon jenkinsci

Please add a way to disable the 'can one of the admins verify this patch' comment

Open jschmid1 opened this issue 6 years ago • 11 comments

If you have rather strict rules on whether you are allowed to trigger tests or not, you can't enable the Build every pull request automatically without asking (Dangerous!). option which would disable the warning.

I found the option to change the default message, which is nice but simply not enough. We have multiple jobs with the jenkins pr builder that point to one repo and can be triggered by different trigger phrases. By not having the possiblity to disable these comments every new contributor gets flooded with these messages.

So my request would be to have a job-wide(not system-wide) switch to toggle these warnings.

jschmid1 avatar Dec 15 '17 15:12 jschmid1

Seconding this^. We have the exact same "problem" - having three jobs polling the PRs, this already floods the PR comments.

manovotn avatar Mar 08 '18 10:03 manovotn

Yeah, in our case (and I think many others) this comment ends up being spammy and not necessarily required.

skyler3d avatar Apr 11 '18 13:04 skyler3d

Can you attach a screenshot of your settings please? Or even better the config file you are using? Both system and job configuration.

bjoernhaeuser avatar Apr 27 '18 20:04 bjoernhaeuser

Yes, this would really be nice to have

pkubatrh avatar Sep 23 '19 08:09 pkubatrh

Has this been added yet? Want to get Jenkins to not comment on any PRs at all and only leave its status there and thats it.

EdwardW2 avatar Oct 24 '19 08:10 EdwardW2

Any update on this? although I whitelisted the users with the github user name the comment "Can one of the admins verify this patch?" is still auto generated?

ArthiIreddy avatar Dec 03 '19 17:12 ArthiIreddy

Would also love if this feature could be added.

dooleyb1 avatar Dec 09 '19 11:12 dooleyb1

Can one of the admins verify this patch? 🙄

wimglenn avatar Apr 08 '20 15:04 wimglenn

It would be very nice to have!

frenzymadness avatar Apr 29 '20 08:04 frenzymadness

I would also like to disable this message. It seems, that there are also differences within versions. In an older one I was able to disbale it by enabling "build every pull-request (dangeorus)" and setting a whitelist of users.

Pymann avatar Aug 31 '20 08:08 Pymann

We've been running into this issue with our Jenkins setup, such as on this PR https://github.com/opensearch-project/OpenSearch/pull/1943

peternied avatar Jan 19 '22 23:01 peternied