ghprb-plugin icon indicating copy to clipboard operation
ghprb-plugin copied to clipboard

Canceled builds don't update github status (it's forever pending)

Open benpatterson opened this issue 8 years ago • 4 comments

Posting an example screenshot. I think it's confusing and we should try & think of a solution...

This screenshot shows commit '14' listed as pending even though the build itself was aborted when '15' landed.

image

benpatterson avatar Oct 12 '16 00:10 benpatterson

There is no way to delete a status.

Do what should we set it? FAILED I assume?

bjoernhaeuser avatar Nov 24 '17 20:11 bjoernhaeuser

Also there is no way to register a listener on canceled builds as far as I an see. :(

bjoernhaeuser avatar Nov 24 '17 20:11 bjoernhaeuser

Hello @bjoernhaeuser I suggest we list it as failed, because it did not complete. But, I'm not firm on that thinking.

I also suspect this is lower on the priority list than other open issues. I have no problem if you want to close it as "won't work on this in the near-term."

benpatterson avatar Apr 10 '18 16:04 benpatterson

There are just 4 possible statuses in GitHub checks - error, failure, pending, or success. Aborted job is actually nothing of those. Maybe a good solution will be at least to replace "Pending — Build started" with "Pending - Build aborted".

More about GitHub statuses.

primoz-p avatar Feb 12 '21 15:02 primoz-p