ghprb-plugin icon indicating copy to clipboard operation
ghprb-plugin copied to clipboard

Trigger phrases don't trigger from PR description

Open jekhardt opened this issue 9 years ago • 4 comments

Comments work okay, but it would be very helpful to have the description also be a source to check for trigger phrases. We have a pull request description template contains options of available trigger phrases, but they don't do anything unless the author always makes a new comment. It would be helpful to save a few hundred copy pastes each day.

jekhardt avatar Aug 05 '16 02:08 jekhardt

Based on this description, I wonder, are new commits not sufficient for kicking off the build for you? What you're describing may not be available in GitHub webhooks.

benpatterson avatar Sep 30 '16 10:09 benpatterson

Clarifying note. I think the author wants:

  • builds via webhook
  • only build by trigger phrase
  • [enhancement] recognize trigger phrase on commit message

benpatterson avatar Oct 09 '16 18:10 benpatterson

@jekhardt I'm not sure if the author would like the trigger phrase to be recognised on commit message or on the initial description added @benpatterson Please clarify.

I've noticed that when the initial comment is added when opening a PR it is treated as ghprbPullLongDescription and not ghprbCommentBody meaning it does not trigger the job from the trigger phrase. It would be very useful to add this functionality where it will check the ghprbPullLongDescription for the trigger phrase also. If this is not the same request I will open a new issue.

davetobin avatar Jul 04 '17 10:07 davetobin

FWIW, this was for the pull request body description field in GitHub to be a source to check for patterns. PullLongDescription sounds like the right request.

jekhardt avatar May 02 '24 00:05 jekhardt