folder-auth-plugin
folder-auth-plugin copied to clipboard
jenkinsci
Add new API GET methods
I thought it'll be good to have GET methods as well. This will allow admins to write automation (eg. reports for publishing user access info) on the plugin without having to resort to script console.
ah it looks like the PR-merge build failed due to an issue on the agent? i'll close and reopen the PR to induce a rebuild
Thanks a lot @blanked ! I will try to review this PR as soon as possible.
@kalyantag Sorry, I got busy with other things and forgot about this PR. I will review it this weekend.
@blanked Thanks a lot! Looks like the build is failing because of missing @throws in JavaDocs.
Exit code: 1 - /home/jenkins/workspace/Plugins_folder-auth-plugin_PR-69/src/main/java/io/jenkins/plugins/folderauth/FolderAuthorizationStrategyManagementLink.java:459: warning: no @throws for java.io.IOException
@blanked Thanks a lot! Looks like the build is failing because of missing
@throwsin JavaDocs.Exit code: 1 - /home/jenkins/workspace/Plugins_folder-auth-plugin_PR-69/src/main/java/io/jenkins/plugins/folderauth/FolderAuthorizationStrategyManagementLink.java:459: warning: no @throws for java.io.IOException
Oh the throws IOException was meant to be removed due to the removal of stapler writer but I missed it.
Ok I've implemented the suggestions. Can you take another look and see if the PR is good to go? Thanks @AbhyudayaSharma
I think the build can be restarted by pushing an empty commit (git commit --allow-empty) or closing it, waiting for 2 minutes and then reopening. I also believe that there was a hook added to rebuild from comments on pull requests in last year's GSoC. I will try to find whether it is available on ci.jenkins.io
From: Hui Jun [email protected] Sent: Saturday, 6 March 2021, 21:17 To: jenkinsci/folder-auth-plugin Cc: Abhyudaya Sharma; Mention Subject: Re: [jenkinsci/folder-auth-plugin] Add new API GET methods (#69)
Ok is there any way of retriggering the tests? It seems like there were problems on the agent for the build. Closing and reopening doesn't seem to trigger a new build
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/jenkinsci/folder-auth-plugin/pull/69#issuecomment-791975089, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACXQV3YDJYIBITKSPEIJW4TTCJFB7ANCNFSM4S5SCAPA.
Ok I finally got a build to run successfully. I believe I've addressed all of the comments/suggestion. Let me know if there are any other comments/suggestions? Thanks!
Hi @oleg-nenashev ! If you have some time, could you please take a quick look at this PR?
Hi @blanked. Sorry for the delay. What would you think about exporting the entire plugin configuration as JSON as done in https://github.com/jenkinsci/folder-auth-plugin/pull/58/files#diff-237f6cdc333b75a3ea591296a855f117edf78bb4ec1f9cbbc2391811e672304d?