environment-dashboard-plugin icon indicating copy to clipboard operation
environment-dashboard-plugin copied to clipboard

Published 20 hours ago • verified publisher icon jenkinsci

Refactor to fix spotbugs identified issues

Open willwh opened this issue 5 years ago • 0 comments

Running mvn spotbugs:check against the plugin, there are a number of issues that we should likely address.

There is also a comment from @slide in Jenkins JIRA;

You may want to use req.bindJson rather than looking at the JSON data directly. https://github.com/vipinsthename/environment-dashboard/blob/master/src/main/java/org/jenkinsci/plugins/environmentdashboard/DashboardBuilder.java#L342 and here https://github.com/vipinsthename/environment-dashboard/blob/master/src/main/java/org/jenkinsci/plugins/environmentdashboard/EnvDashboardView.java#L232

willwh avatar Oct 25 '19 16:10 willwh