docker icon indicating copy to clipboard operation
docker copied to clipboard

Remove dependency on latest/ directory

Open daniel-beck opened this issue 4 years ago • 8 comments

The update center will stop providing tiered latest/ directories soon.

Please adapt install-plugins.sh to work without that.

I had switched to the new version of the update site generator yesterday, and these issues were filed: https://issues.jenkins-ci.org/browse/INFRA-2614 https://github.com/jenkinsci/docker/issues/952#issuecomment-626296534

daniel-beck avatar May 10 '20 09:05 daniel-beck

Can you give some details on what the structure will look like?

slide avatar May 14 '20 00:05 slide

@slide It's unclear what you're asking. These directories will no longer be generated.

See e.g. https://issues.jenkins-ci.org/browse/INFRA-2615 for a change I plan to implement that will make the existence of update site tiers dependent on what plugins actually declare.

Instead, request /update-center.actual.json?version=2.xyz and download plugins from the URLs specified there.

daniel-beck avatar May 15 '20 17:05 daniel-beck

Ok, that makes more sense.

slide avatar May 15 '20 17:05 slide

One thing I noticed is that if you provide a bogus Jenkins version, e.g., https://updates.jenkins.io/update-center.actual.json?version=4.0 you still get update center information returned. I am not sure if this is desirable in all cases.

slide avatar May 15 '20 18:05 slide

@slide In that particular case, we provide the current update site, treating it like the latest weekly. Seems reasonable. 2.0 will be redirected to 2.164, the non-existing 2.0.1 to stable-2.164.

We redirect all 1.x versions to the latest, but it really doesn't make that much of a difference anymore, upgrading core is the only thing that matters. Are you seeing other redirects that don't make sense?

daniel-beck avatar May 15 '20 19:05 daniel-beck