docker-workflow-plugin icon indicating copy to clipboard operation
docker-workflow-plugin copied to clipboard

DockerClient.version() falls back to trying '--version'

Open renat1sakenov opened this issue 5 years ago • 3 comments

Hello.

As far as I can tell, only '-v' option is used to determine the docker version.

I added a fallback to check again for '--version', since I'm trying to make this run with podman instead of docker. Podman does not support the '-v' flag.

Best, Renat

renat1sakenov avatar Apr 09 '20 10:04 renat1sakenov

The -v shorthand is available with podman 1.6 (again) . However, as @95jonpet I'd prefer --version, especially to avoid confusion with --volume's shorthand.

offa avatar Apr 28 '21 08:04 offa

Fully agree, I commited the change to only check for --version.

renat1sakenov avatar May 01 '21 20:05 renat1sakenov

ping @rsandell

offa avatar Feb 04 '22 09:02 offa