docker-workflow-plugin
docker-workflow-plugin copied to clipboard
jenkinsci
JENKINS-48417 Add the ability to run docker container in foreground
Following the linked issue, we are missing a way in order to run a container which is only playing foreground command.
e.g.: this is quite useful for a Dockerfile used for compilation.
I think that such feature is only meaningful in the run step.
Effectively, withRun & inside are dedicated to interact with the container, whereas run in foreground means that the image has a self-sufficent embedded command.
Can this please be merged? It looks like it was approved and all checks passed.
Would love to see this PR merged. Can you consider doing it? Kind regards. Stan
@jetersen @jglick
Please someone in jenkinsci take a look at this or notify the correct people to take a look.
I am not maintaining this plugin and am not sure if anyone is. My standing advice is to avoid using DSL features if at all possible; use sh 'docker run …' however you like.
@oleg-nenashev Can you put me in contact with someone at cloudbees? This plugin has lots of CI/CD and plenty of open PR's with passing build and valuable fixes/features. It's hard to believe cloudbees of all orgs has abandoned it. I would be willing to volunteer some time to get most of these PR's merged and released over the next couple of months.
@car-roll I saw that the latest PRs in this project are merged by you. Can you please merge this one too 🙏 🙏
At present this plugin needs some review as to whether or not it is bringing more value than passing docker commands through a shell step (as jesse mentioned above). I am unaware of the details, but I recall that there are some existing behaviors in here that need to be fixed.
@car-roll With 5000+ installs per day I would say the community finds value in this plugin.
EDIT: I might have miss read the plugin installs chart https://plugins.jenkins.io/docker-workflow/ so I'm not sure how many installs.
@oleg-nenashev It seems like this plugin needs some help with maintaining it.
I don't exactly know much about maintaining a Jenkins Plugin, nor am I a strong Java programmer but in true LOTR fashion...
If by my nights or weekends I can maintain it, I will. You have my keyboard!
With 5000+ installs
~168k current installations according to the plugin page. Beware of using installation count as a proxy for usage, though. Among other things, this plugin was until fairly recently a dependency of pipeline-model-definition a.k.a. Declarative Pipeline, which gets installed by default in new systems by the setup wizard—so there are likely tens of thousands of enabled even though unused copies of this plugin.
All that is not to say that this plugin is not widely used—it is—merely that it is difficult to get accurate numbers without finer-grained usage metrics.
Hello everybody. Is there any chance that this PR will be merged?
cc @car-roll
