docker-ssh-agent icon indicating copy to clipboard operation
docker-ssh-agent copied to clipboard

fix(windows): use `git-lfs` installer and bump its version to 3.5.1

Open lemeurherve opened this issue 1 year ago • 5 comments

Same as https://github.com/jenkinsci/docker-agent/pull/503, this PR mainly add git to the PATH before running git-lfs.exe install instead of git lfs install to avoir the error git: 'lfs' is not a git command. encountered when bumping git-lfs to its 3.4.0 version, cf https://github.com/jenkinsci/docker-ssh-agent/pull/277#issuecomment-1630239571

Other notable changes:

  • test added to check if git-lfs (and thus git) is installed and in the PATH
  • trimprefix added to the git-lfs source in the corresponding updatecli manifest, easier to work with in files operations and in test

Supersedes and closes #277

Testing done

### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [x] Link to relevant issues in GitHub or Jira
- [x] Link to relevant pull requests, esp. upstream and downstream changes
- [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

lemeurherve avatar Sep 15 '23 10:09 lemeurherve