docker-agent
docker-agent copied to clipboard
jenkinsci
Revert Git version on Windows from `2.50.0.windows.1` to `2.49.0.windows.1`
Reverts jenkinsci/docker-agent#1001
See https://github.com/jenkinsci/docker-agent/issues/1005 and https://github.com/jenkinsci/docker-agent/pull/1001#issuecomment-2983362123
Counter proposal: https://github.com/jenkinsci/docker-agent/issues/1005#issuecomment-3004035701
Since we're going to describe the "known" issue in the release notes, it means: should we rollback, or wait for a fix on upstream git?
cc @gounthar (as platform SIG leader so the subject is tracked) @MarkEWaite @jonesbusy @lemeurherveCB
The workarounds seem fine to me: people blocked by the issue and that can't switch to HTTPS will have to roll back or to deploy a potential new version including 2.49.
For everyone else (able to switch to HTTPS), having those workarounds in the release notes avoid them to deploy a potential new version including 2.49
Thus, not creating a new version with 2.49 seem to require less effort for the majority of people.
Since we're going to describe the "known" issue in the release notes, it means: should we rollback, or wait for a fix on upstream git?
cc @gounthar (as platform SIG leader so the subject is tracked) @MarkEWaite @jonesbusy @lemeurherveCB
The fix seems to be progressing through Git for Windows rapidly. That is consistent with how the Git for Windows maintainer has worked in the past.
If the fix is available from Git for Windows by start of day Friday, I think we could skip the revert and apply 2.50.1 on Friday (or sooner). If we reach Friday and don't have a fix from Git for Windows, I think we need to revert to 2.49.0 in the image. There are certainly use cases where users won't want to change the authentication method for their repository and there are even cases where they can't change the authentication method and have it continue to work. For example, if submodules are defined by ssh URL in the repository, then switching to https for clone will cause the submodule clone to fail.
Since Git for Windows 2.50.1 has not yet released, I think that we need to merge this pull request so that user performing ssh clones with the agent container image will not be disrupted.