design-library-plugin icon indicating copy to clipboard operation
design-library-plugin copied to clipboard

draft: Add 'Layouts' page

Open janfaracik opened this issue 2 years ago • 3 comments

image

An early attempt at some guidance on the various layouts Jenkins supports.

Would be great to get thoughts/ideas/contributions 👍

⚠️ App bars don't work correctly at the moment the way the Design Library uses them, this will be fixed

janfaracik avatar Jul 18 '22 20:07 janfaracik

Looks really good, is it worth having child pages of this that has actual rendered examples?

Good idea! I've updated the code component to include a button to open the preview in a new tab. The way it works isn't ideal (lots of code duplication) but it's a start.

image

janfaracik avatar Jul 20 '22 08:07 janfaracik

any reason this is still in draft?

timja avatar Aug 15 '22 15:08 timja

any reason this is still in draft?

There's a change to core I need to make relating to app bars first (small change to their placement in code), wanting to cut down on existing PRs first just to reduce mental load before opening it.

janfaracik avatar Aug 15 '22 17:08 janfaracik

Happy to give this a tick @timja and I'll merge it?

janfaracik avatar Oct 13 '22 20:10 janfaracik

doesn't jenkins.version in pom.xml need to be 2.374?

Ah yes it'll need to be the weekly the app bar change was merged in, otherwise each page will lack a heading.

image

v2.371

janfaracik avatar Oct 13 '22 21:10 janfaracik