design-library-plugin icon indicating copy to clipboard operation
design-library-plugin copied to clipboard

Published 20 hours ago • verified publisher icon jenkinsci

Sidepanel/app bar rule needs changes

Open daniel-beck opened this issue 1 year ago • 1 comments

Per @janfaracik

What underlying principle motivates this change? It does not seem to be justified by https://weekly.ci.jenkins.io/design-library/AppBar/

It'd align more so with https://weekly.ci.jenkins.io/design-library/Layouts/ 'Don't include actions or external pages in your sidebar, these belong in the top app bar'. It'd be consistent with the 'Log Recorders' interface.

AFAICT, https://github.com/jenkinsci/jenkins/pull/8381#issuecomment-1688106640,

This rule basically invalidates every RootAction.

Given how common RootActions are, and the widespread impact of declaring that use of the sidepanel invalid, the rule should be overhauled.

daniel-beck avatar Aug 22 '23 12:08 daniel-beck