dependency-check-plugin icon indicating copy to clipboard operation
dependency-check-plugin copied to clipboard

give the correct (reversed) priority to the drawn chart lines

Open swiss-chris opened this issue 2 years ago • 1 comments

it seems that echarts gives the highest priority to the series defined last. So if we want critical vulnerabilities to be seen, even if there are lower ranking vulnerabilities with the same occurrence, then we need to define the critical series last.

  • [ ] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • [x] Ensure that the pull request title represents the desired changelog entry
  • [x] Please describe what you did
  • [ ] Link to relevant issues in GitHub or Jira
  • [ ] Link to relevant pull requests, esp. upstream and downstream changes
  • [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

swiss-chris avatar Mar 14 '22 15:03 swiss-chris

@kudos-dude what (else) would I need to do to get this PR looked at and merged by a maintainer?

swiss-chris avatar Mar 15 '22 16:03 swiss-chris

chart.js has been replaced by echart-api-plugin

nfalco79 avatar Dec 09 '22 10:12 nfalco79

chart.js has been replaced by echart-api-plugin

That's great, but did anyone fix (or even look at) my issue, or will I have to start all over again ? And if I open another issue, will someone take notice ? My last one went without a reaction on your part for 9 months and then was simply closed.

swiss-chris avatar Dec 09 '22 10:12 swiss-chris

I simply close because I use the jenkins plugin that make me transparent how to render the trend graph. Now I have only to prepare the dataset. All the render work is done but the echart-api-plugin

nfalco79 avatar Dec 09 '22 10:12 nfalco79

I saw now what you changed. I applied them on the severity enumeration order so that in case two or more severity has the same value than the shown line is colored with the color of most critical severity

nfalco79 avatar Dec 09 '22 10:12 nfalco79

I saw now what you changed. I applied them on the severity enumeration order so that in case two or more severity has the same value than the shown line is colored with the color of most critical severity

Brilliant !! Thank You 🙏

swiss-chris avatar Dec 09 '22 10:12 swiss-chris

But it will be released in 5.2.2 image The Low trend green line is over the Unussigned trend line

nfalco79 avatar Dec 09 '22 10:12 nfalco79